Skip to content

feat(crypto): migrate to Core Crypto v10 [WPB-8645] - #5204

Merged
MohamadJaara merged 2 commits into
developfrom
mo/test-cc-v10
Sep 2, 2026
Merged

feat(crypto): migrate to Core Crypto v10 [WPB-8645]#5204
MohamadJaara merged 2 commits into
developfrom
mo/test-cc-v10

Conversation

@MohamadJaara

@MohamadJaara MohamadJaara commented Aug 24, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@MohamadJaara MohamadJaara changed the title feat(crypto): migrate to Core Crypto v10 feat(crypto): migrate to Core Crypto v10 [WPB-8645] Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Test Results

2 668 tests  +4   2 668 ✅ +4   1m 43s ⏱️ +7s
  338 suites +1       0 💤 ±0 
  338 files   +1       0 ❌ ±0 

Results for commit 114dd22. ± Comparison against base commit ee9b66a.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara
MohamadJaara requested a review from a team as a code owner August 24, 2026 15:34
@MohamadJaara
MohamadJaara requested review from Garzas and sbakhtiarov and removed request for a team August 24, 2026 15:34
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

sbakhtiarov
sbakhtiarov previously approved these changes Aug 25, 2026
View reviewed changes
@codecov

codecov Bot commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.52174% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.03%. Comparing base (ee9b66a) to head (114dd22).

Files with missing lines Patch % Lines
...d/ui/e2eiEnrollment/GetE2EICertificateViewModel.kt 59.25% 9 Missing and 2 partials ⚠️
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 0.00% 3 Missing ⚠️
...droid/ui/e2eiEnrollment/E2EIEnrollmentViewModel.kt 0.00% 2 Missing ⚠️
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 0.00% 2 Missing ⚠️
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (56.52%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #5204      +/-   ##
===========================================
+ Coverage    52.93%   53.03%   +0.10%     
===========================================
  Files          744      745       +1     
  Lines        25820    25824       +4     
  Branches      4240     4236       -4     
===========================================
+ Hits         13669    13697      +28     
+ Misses       10817    10792      -25     
- Partials      1334     1335       +1
Files with missing lines Coverage Δ
.../android/ui/e2eiEnrollment/GetE2EICertificateUI.kt 100.00% <100.00%> (ø)
...droid/ui/e2eiEnrollment/E2EIEnrollmentViewModel.kt 48.38% <0.00%> (ø)
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 59.44% <0.00%> (ø)
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 68.18% <0.00%> (ø)
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 56.04% <0.00%> (+1.49%) ⬆️
...d/ui/e2eiEnrollment/GetE2EICertificateViewModel.kt 44.44% <59.25%> (+44.44%) ⬆️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9b66a...114dd22. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@pull-request-size pull-request-size Bot added size/M and removed size/XS labels Sep 1, 2026
@MohamadJaara
MohamadJaara dismissed sbakhtiarov’s stale review September 1, 2026 14:13

need to dismiss this review since the code in kalium changed a bit and need to update the app

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara
MohamadJaara merged commit c3b770d into develop Sep 2, 2026
21 checks passed
@MohamadJaara
MohamadJaara deleted the mo/test-cc-v10 branch September 2, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android
@sbakhtiarov sbakhtiarov Awaiting requested review from sbakhtiarov

Assignees

@MohamadJaara MohamadJaara

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MohamadJaara @sbakhtiarov